[PATCH v2 00/20] mesh support for wpa_supplicant

Bob Copeland me at bobcopeland.com
Thu Nov 20 09:36:53 EST 2014


On Thu, Nov 20, 2014 at 04:29:53PM +0200, Jouni Malinen wrote:
> On Wed, Oct 22, 2014 at 12:01:47AM -0400, Bob Copeland wrote:
> > On Sun, Oct 05, 2014 at 10:47:48PM +0300, Jouni Malinen wrote:
> > >     nl80211: Do not set zero STA capability (mesh)
> > 
> > I think the intent here was actually to avoid nl80211_set_station() failing
> > when capability was specified at all for mesh interfaces, as with supp rates.
> > So perhaps it should go under if (!params->set) {} conditional instead.
> 
> OK, that makes more sense. I'll address all the capability attributes
> similarly to supported rates. I'm assuming these could end up being
> needed for TDLS (which is allowed in cfg80211 for _SET), so the exact
> same condition should apply.

Great, thanks!

> Any additional comments on this one? The hwsim test cases pass even if
> this patch is not applied.

I was just looking at that -- please drop.

Reasoning:

 - NL80211_ATTR_KEY_DEFAULT{,_MGMT} are already set for tx keys later in
   the function

 - setting KEYTYPE_GROUP is unnecessary as kernel already does the right
   thing if peer mac is not supplied.

-- 
Bob Copeland %% http://bobcopeland.com/


More information about the HostAP mailing list