[PATCH v2 00/20] mesh support for wpa_supplicant

Jouni Malinen j at w1.fi
Thu Nov 20 09:29:53 EST 2014


On Wed, Oct 22, 2014 at 12:01:47AM -0400, Bob Copeland wrote:
> On Sun, Oct 05, 2014 at 10:47:48PM +0300, Jouni Malinen wrote:
> >     nl80211: Do not set zero STA capability (mesh)
> 
> I think the intent here was actually to avoid nl80211_set_station() failing
> when capability was specified at all for mesh interfaces, as with supp rates.
> So perhaps it should go under if (!params->set) {} conditional instead.

OK, that makes more sense. I'll address all the capability attributes
similarly to supported rates. I'm assuming these could end up being
needed for TDLS (which is allowed in cfg80211 for _SET), so the exact
same condition should apply.

> >     nl80211: set_key updates for mesh

Any additional comments on this one? The hwsim test cases pass even if
this patch is not applied.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list