[PATCH 03/12] mesh: Add action processing for mesh

Masashi Honma masashi.honma at gmail.com
Tue Nov 4 19:08:23 EST 2014


Yeah... "GROUP" is not mesh term.
MESH_BSS is better.
But the word GROUP is used on other mesh source codes.
So I think it should be replaced after almost implementation was done.

2014-11-04 22:53 GMT+09:00 Bob Copeland <me at bobcopeland.com>:
> On Tue, Nov 04, 2014 at 02:36:44PM +0900, Masashi Honma wrote:
>> Signed-off-by: Natsuki Itaya <Natsuki.Itaya at jp.sony.com>
>> Signed-off-by: Masashi Honma <masashi.honma at gmail.com>
>> ---
>>  wpa_supplicant/wpa_cli.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
>> index 1e1d029..25ac4c2 100644
>> --- a/wpa_supplicant/wpa_cli.c
>> +++ b/wpa_supplicant/wpa_cli.c
>> @@ -3280,6 +3280,14 @@ static void wpa_cli_action_process(const char *msg)
>>                       wpa_cli_connected = 0;
>>                       wpa_cli_exec(action_file, ifname, "DISCONNECTED");
>>               }
>> +     } else if (str_match(pos, MESH_GROUP_STARTED)) {
>> +             wpa_cli_exec(action_file, ctrl_ifname, pos);
>> +     } else if (str_match(pos, MESH_GROUP_REMOVED)) {
>> +             wpa_cli_exec(action_file, ctrl_ifname, pos);
>
> This reminds me - I know "MESH_GROUP" was chosen for similarity to
> P2P.  I don't happen to know if any software expects this naming yet.
> But would it make sense to use "MESH_BSS" or something similar since
> one is more likely to encounter that language?
>
> --
> Bob Copeland %% www.bobcopeland.com


More information about the HostAP mailing list