[PATCH] hostapd: Remove redundant freeing of STA list entries

Mohammed Shafi Shajakhan mohammed at qca.qualcomm.com
Tue May 21 01:16:55 EDT 2013


On Sun, May 19, 2013 at 10:28:24PM +0300, Jouni Malinen wrote:
> On Fri, May 17, 2013 at 10:49:14AM +0530, Mohammed Shafi Shajakhan wrote:
> > On Thu, May 16, 2013 at 08:55:00PM +0300, Jouni Malinen wrote:
> > > On Thu, May 16, 2013 at 04:44:04PM +0530, Mohammed Shafi Shajakhan wrote:
> > > > hostapd_flush_old_stations does this appropriately
> > > > after flushing the STA entries in the driver.
> > > 
> > > The hostapd_free_stas() call in hostapd_flush_old_stations() is
> > > conditional, i.e., the call here would still be needed for the
> > > driver=none case.
> > 
> > does driver=none maintains a sta list ?
> 
> Probably not for most use cases, but it could potentially be used for
> RSN pre-authentication testing where a STA entry may be created.
> 
> Does this patch fix something or is it just cleanup?

no Jouni, its a cleanup, haven't found any issue that this fixes.

> 
> -- 
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap


More information about the HostAP mailing list