[Projekt-wlan] [PATCH v4 01/25] Remove WPA per-VLAN groups when all stations left on rekeying

michael-dev michael-dev at fami-braun.de
Sun Aug 4 15:15:30 EDT 2013


Hi,

Am 04.08.2013 20:33, schrieb Jouni Malinen:
> On Sat, Jul 27, 2013 at 09:54:31PM +0200, Michael Braun wrote:
>> This adds a references counter to struct wpa_group and frees
>> a group if it is unused.
> Could you please clarify why there is an eloop timeout used in this
> design?

basically its there because I was afraid of causing a NULL pointer 
dereference while writing that code. That was because I was unsure if 
that station vlan removal code could ever happen to be called indirectly 
while somebody is still accessing that very group - for example on of 
the iterators in wpa_auth.c (i.e. wpa_rekey_gtk). Using a timeout makes 
sure that the function is called directly from the eloop, so there 
wouldn't be any other context around.
On the other hand, such a call seems unlikely to me now - though the 
wpa_auth_sta_set_vlan code might need to be updated.

I'll send a refreshed version.

Regards,
  M. Braun


More information about the HostAP mailing list