[PATCH v4 01/25] Remove WPA per-VLAN groups when all stations left on rekeying

Jouni Malinen j at w1.fi
Sun Aug 4 14:33:32 EDT 2013


On Sat, Jul 27, 2013 at 09:54:31PM +0200, Michael Braun wrote:
> This adds a references counter to struct wpa_group and frees
> a group if it is unused.
> 
> This is useful when extending the number of VLANs supported.
> 
> Signed-hostap: Michael Braun <michael-dev at fami-braun.de>
> 
> V3: Freeing is not done in rekeying timer anymore.

Could you please clarify why there is an eloop timeout used in this
design? The commit log does not mention that at all and the code looks
overly complex as-is unless there is some clear need for this five
second timeout. Is the goal here to try to avoid removing the group if
another STA starts using it in five seconds? Is this really worth the
extra complexity?

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list