[PATCH] dbus: Making the peer's properties acessible separately

Jouni Malinen j at w1.fi
Sun Feb 12 05:28:30 EST 2012

On Sat, Feb 11, 2012 at 05:29:52PM -0600, Dan Williams wrote:
> > > +	{"config_method", WPAS_DBUS_NEW_IFACE_P2P_PEER, "n",
> > > +	{"level", WPAS_DBUS_NEW_IFACE_P2P_PEER, "au",
> > > +	{"SecondaryDeviceTypes", WPAS_DBUS_NEW_IFACE_P2P_PEER, "au",

> Hmm, using 'n' is pretty weird here since that's a 16-bit signed
> integer.  I wonder why it wasn't just 'u' (32-bit unsigned).

I replaced that with "q" to match with DBUS_TYPE_UINT16.

> The 'au' is "array of uint32" which should be fine,

Well.. level is actually a signed integer, so "au" was quite odd for it
(I replaced this with "i"). As far as SecondaryDeviceTypes are
concerned, array of 32-bit unsigned integers sounds a bit odd. The
device type is an 8-octet field (which can also be presented as a string
like 1-0050F204-1) and this field would be an array of those. For now, I
replaced that with "ay", but I'm not sure whether that really is the
best approach.

> but something else odd here
> is that the P2P properties are mixed between StudlyCaps and
> underscore_separated formats.  For consistency they should probably be
> using one or the other, preferably StudlyCaps since that's the dbus
> convention.

I was tempted to change these, but then noticed that these came from the
previously used dictionary and left the strings unchanged.

Jouni Malinen                                            PGP id EFC895FA

More information about the HostAP mailing list