[PATCH] dbus: Making the peer's properties acessible separately

Dan Williams dcbw at redhat.com
Sat Feb 11 18:29:52 EST 2012


On Sat, 2012-02-11 at 11:43 +0200, Jouni Malinen wrote:
> On Fri, Feb 03, 2012 at 06:52:18PM -0200, Flávio Ceolin wrote:
> > How there is the method org.freedesktop.DBus.Properties.GetAll
> > that returns all properties from a specific interface, makes more
> > sense separate the properties to be possible to get only a specific
> > property using the method org.freedesktop.DBus.Properties.Get.
> 
> Thanks! Applied.
> 
> > diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
> >  static const struct wpa_dbus_property_desc wpas_dbus_p2p_peer_properties[] = {
> > +	{"config_method", WPAS_DBUS_NEW_IFACE_P2P_PEER, "n",
> > +	{"level", WPAS_DBUS_NEW_IFACE_P2P_PEER, "au",
> > +	{"SecondaryDeviceTypes", WPAS_DBUS_NEW_IFACE_P2P_PEER, "au",
> 
> There were incorrect D-Bus types in the introspect information. I tried
> to correct these (and one type in the handler functions, too). Please
> verify that the end result matches with what you would like to see
> there.

Hmm, using 'n' is pretty weird here since that's a 16-bit signed
integer.  I wonder why it wasn't just 'u' (32-bit unsigned).  The 'au'
is "array of uint32" which should be fine, but something else odd here
is that the P2P properties are mixed between StudlyCaps and
underscore_separated formats.  For consistency they should probably be
using one or the other, preferably StudlyCaps since that's the dbus
convention.

Dan




More information about the HostAP mailing list