[PATCH] P2P: Fix crash for failure case when WSC PIN is entered incorrectly.

Jouni Malinen j at w1.fi
Fri Apr 6 11:26:06 EDT 2012


On Tue, Apr 03, 2012 at 02:55:48PM -0700, Angie Chinchilla wrote:
> When forming a P2P group using WSC PIN method, if the pin is entered
> incorrectly the P2P client supplicant instance will crash as a result
> of cleanup happening on data that is still in use.

> - which calls wpa_supplicant_remove_iface()
> - which calls wpa_supplicant_deinit_iface()
> - which calls wpa_supplicant_cleanup()

This part is limited to the case where a separate P2P group interface is
used. I've tested this type of sequences many times in the past, but
apparently not with a group interface.

> If you fix this crash, you'll hit another. Fix it and then a segfault.
> The way we're cleaning up and deleting data from under ourselves here
> just isn't safe, so make the teardown portion of this async.

Thanks! Applied.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list