[PATCH] Complete the support of P2P in the 5GHz band

Marotte, Fabien fabien.marotte at intel.com
Mon Apr 2 05:39:47 EDT 2012


> > The 5GHz band was not fully supported in the P2P case.
> > This patch fixes the P2P code lacks.
> 
> This was left out on purpose to avoid enabling some channels (especially, anything requiring DFS). Similarly, HT40 negotiation is quite unclear topic and it seems it would be clearer to just negotiate
> HT20 and have the GO enable HT40 on its own.
I see what you mean for HT40.
However, some HT40 classes were already defined in the 5GHz band before my patch. That's why I added the others.

>
> > What are you trying to achieve with the changes in this patch?
My primary goal was to activate channel 165 that is not supported.
However, I wanted my patch to be "complete". That's why I added all the classes.

>
> > diff --git a/wpa_supplicant/p2p_supplicant.c 
> > b/wpa_supplicant/p2p_supplicant.c @@ -2177,9 +2177,16 @@ static int 
> > wpas_p2p_setup_channels(struct wpa_supplicant *wpa_s,
> > +		{ HOSTAPD_MODE_IEEE80211A, 118, 52, 64, 4, BW20 },
> > +		{ HOSTAPD_MODE_IEEE80211A, 119, 52, 60, 8, BW40PLUS },
> > +		{ HOSTAPD_MODE_IEEE80211A, 120, 56, 64, 8, BW40MINUS },
> > +		{ HOSTAPD_MODE_IEEE80211A, 121, 100, 140, 4, BW20 },
> > +		{ HOSTAPD_MODE_IEEE80211A, 122, 100, 132, 8, BW40PLUS },
> > +		{ HOSTAPD_MODE_IEEE80211A, 123, 104, 136, 8, BW40MINUS },
>
> I'm not planning on enabling DFS channels for P2P use cases, so especially this section would require quite a bit more justification.
I understand why you don't plan to activate DFS channels.
However, define the class 118 to 123 is not a problem because the function has_channel(), (lower is setup_channels() ) will filter the DFS channels.
So according to me, it should not be a matter to define them here.

>

I can re-push a new patch depending on what you prefer to see in the code.

Fabien

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



More information about the HostAP mailing list