[PATCH] DBus: add ability to report probe requests

Jouni Malinen j at w1.fi
Sun Apr 1 14:32:38 EDT 2012


On Mon, Mar 05, 2012 at 09:04:48AM +0100, Johannes Berg wrote:
> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> @@ -2335,8 +2337,23 @@ void wpa_supplicant_event(void *ctx, enum wpa_event_type event,
> +		if (stype == WLAN_FC_STYPE_PROBE_REQ &&
> +		    data->rx_mgmt.frame_len > 24) {
> +			const u8 *ie = mgmt->u.probe_req.variable;
> +			size_t ie_len = data->rx_mgmt.frame_len -
> +				(mgmt->u.probe_req.variable -
> +				 data->rx_mgmt.frame);
> +
> +			wpas_notify_preq(wpa_s, mgmt->sa, mgmt->da,
> +					 mgmt->bssid, ie, ie_len,
> +					 data->rx_mgmt.ssi_signal);
> +			break;
> +		}
> +
>  		ap_mgmt_rx(wpa_s, &data->rx_mgmt);
>  		break;

Should have actually tested this with full group formation before
applying.. The added "break;" there removes ap_mgmt_rx() calls and
prevents Probe Request frame processing in GO. This results in failed
group formation with mac80211_hwsim (and well, any driver that handle
Probe Request frames in user space). It looks like removing that break
is enough to fix this.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list