[PATCH] P2P: Make GO negotiation peer and group information available over D-Bus

Johannes Berg johannes at sipsolutions.net
Mon Dec 19 11:00:58 EST 2011


On Sun, 2011-12-18 at 16:56 +0200, Jouni Malinen wrote:
> On Tue, Dec 13, 2011 at 10:27:43AM +0100, Johannes Berg wrote:
> > The GO negotiation response is very cryptic at the moment. For a success
> > message we only know on which interface the negotiation succeeded, not
> > which peer. For a failure we know the interface also and a status code
> > (number).
> 
> Well.. There can only be a single GO negotiation in progress, so it
> should be clear which peer was used here at the completion of the
> negotiation.

True.

> > It will be very useful for clients to know upon receipt of such a message
> > which peer the negotiation occurred with.
> > 
> > Now that the peer information is available and the API is changed
> > already, the function composing the D-Bus message might as well include
> > all GO negotiation information. This is done with a dict to make things
> > easier on clients if this result information changes down the line.
> 
> I agree that this can make some operations cleaner on the client and I
> did apply the patch. However, we do need to become a bit more careful on
> changes to the D-Bus interface to avoid problems for programs that
> expect to get a more stable interface for interacting with
> wpa_supplicant.

I agree, but part of the problem is that so far we had very little users
of the APIs, so a lot of these cases haven't really been discovered yet.
I'll look more at compatibility though in future patches.

johannes




More information about the HostAP mailing list