[PATCH] P2P: Make GO negotiation peer and group information available over D-Bus

Jouni Malinen j at w1.fi
Sun Dec 18 09:56:21 EST 2011


On Tue, Dec 13, 2011 at 10:27:43AM +0100, Johannes Berg wrote:
> The GO negotiation response is very cryptic at the moment. For a success
> message we only know on which interface the negotiation succeeded, not
> which peer. For a failure we know the interface also and a status code
> (number).

Well.. There can only be a single GO negotiation in progress, so it
should be clear which peer was used here at the completion of the
negotiation.

> It will be very useful for clients to know upon receipt of such a message
> which peer the negotiation occurred with.
> 
> Now that the peer information is available and the API is changed
> already, the function composing the D-Bus message might as well include
> all GO negotiation information. This is done with a dict to make things
> easier on clients if this result information changes down the line.

I agree that this can make some operations cleaner on the client and I
did apply the patch. However, we do need to become a bit more careful on
changes to the D-Bus interface to avoid problems for programs that
expect to get a more stable interface for interacting with
wpa_supplicant.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list