[osiris-devel] Re: fixing the filters implementation

[David Vasil]

David Vasil wrote:
> David Vasil wrote:
>> I have this written against the current 4.2.2 release (the md_compare.c
>> patch is also added into this patch).  I have not applied this to the
>> current svn trunk yet as I would like to have it tested a little before
>> committing it.  I tested this on Linux (Ubuntu, RHEL, Fedora), OpenBSD
>> (4.0), and Windows (the code works as expected, but filters in general
>> dont appear to work under Windows [have they ever? 4.2.2 without the
>> patches behave the same way]).
>>
>> I added in a function to md_filter.c to create the filter file if it
>> does not exist already by dumping the current filter database to the
>> file.  This will prevent people's filters from being lost after
>> upgrading to this code.
>>
>> I'll be running this code on my system for a while to see how it works
>> out.  If others can run the code or look over it for obvious mistakes,
>> please let me know.
> 
> I've been testing this on my system without a problem for about a week
> now.  If noone has any objections, I'll commit this to the subversion
> trunk and it will be part of the next release.

I have commited this to the 4.2.3 build and have made a release package
for 4.2.3 I'll get Bruce to post soon.  I assume from the lack of
comments on the filters change that everyone is OK with it (has anyone
tried it out?).  Here's a list of things from the ChangeLog that will be
put out for this release:

Differences with version 4.2.3
=================================================

FIXES:

: Windows uninstaller now removes all osiris related registry
  keys during uninstall.
: Linux mod_ports will only attempt to process the tcp
  procfiles if they exist.
: Fixed a bug in the osirismd where the scan context was
  closed too early in the compare routine.
: Fixed a bug in the CLI where print-db would see a race
  condition and fail.
: Fixed the console and agent creation scripts to build the
  OpenBSD packages correctly.
: Lemmings provided a fix to clean up defunct processes being
  created by the osirismd scheduling process.

FEATURES:

: Filters are now stored in a flat text file on the management
  daemon.  Existing filters will be copied from the filter
  database into the flat text file if the flat file does not
  exist at the time of osirismd starting.  This allows the
  filters to keep their order and makes comments in the filters
  much more useful

-- 
-dave