<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Sep 27, 2014 at 10:23 PM, Peer, Ilan <span dir="ltr"><<a href="mailto:ilan.peer@intel.com" target="_blank">ilan.peer@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:hostap-bounces@lists.shmoo.com">hostap-bounces@lists.shmoo.com</a> [mailto:<a href="mailto:hostap-">hostap-</a><br>
> <a href="mailto:bounces@lists.shmoo.com">bounces@lists.shmoo.com</a>] On Behalf Of Dmitry Shmidt<br>
> Sent: Wednesday, September 24, 2014 20:39<br>
> To: <a href="mailto:hostap@lists.shmoo.com">hostap@lists.shmoo.com</a><br>
> Subject: [PATCH] Android: Skip explicit conf_p2p_dev loading for main<br>
> interface<br>
><br>
> It will be loaded later for Non-netdev p2p interface.<br>
><br>
> Change-Id: Ib53daf22c84f2581b499462dc09a74ccfbac226a<br>
> Signed-off-by: Dmitry Shmidt <<a href="mailto:dimitrysh@google.com">dimitrysh@google.com</a>><br>
> ---<br>
> wpa_supplicant/wpa_supplicant.c | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/wpa_supplicant/wpa_supplicant.c<br>
> b/wpa_supplicant/wpa_supplicant.c index f20bc62..9d21fe0 100644<br>
> --- a/wpa_supplicant/wpa_supplicant.c<br>
> +++ b/wpa_supplicant/wpa_supplicant.c<br>
> @@ -3509,7 +3509,9 @@ static int wpa_supplicant_init_iface(struct<br>
> wpa_supplicant *wpa_s,<br>
><br>
> #ifdef CONFIG_P2P<br>
> wpa_s->conf_p2p_dev = os_rel2abs_path(iface-<br>
> >conf_p2p_dev);<br>
> +#ifndef ANDROID_P2P<br>
> wpa_config_read(wpa_s->conf_p2p_dev, wpa_s->conf);<br>
> +#endif<br>
<br>
</div></div>I think it would be cleaner to do the reading only if iface->p2p_mgmt is set (happens only in case a dedicated P2P DEVICE interface is added).<br></blockquote><div><br></div><div>1) iface->p2p_mgmt will be set later.</div><div>2) In case p2p has separate Netdev - it will have its own iterface, in case for Non-netdev it will still load this file</div><div>taking it from parent. Can you please describe the situation when we need to load this file for main interface?</div><div><br></div><div>Thanks,</div><div>Dmitry</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Regards,<br>
<br>
Ilan.<br>
</blockquote></div><br></div></div>