<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Sep 28, 2014 at 11:40 AM, Peer, Ilan <span dir="ltr"><<a href="mailto:ilan.peer@intel.com" target="_blank">ilan.peer@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-style:none none none solid;border-left-color:blue;border-left-width:1.5pt;padding:0cm 0cm 0cm 4pt">
<div>
<div>
<div><span class="">
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12pt">><br>
> diff --git a/wpa_supplicant/wpa_supplicant.c<br>
> b/wpa_supplicant/wpa_supplicant.c index f20bc62..9d21fe0 100644<br>
> --- a/wpa_supplicant/wpa_supplicant.c<br>
> +++ b/wpa_supplicant/wpa_supplicant.c<br>
> @@ -3509,7 +3509,9 @@ static int wpa_supplicant_init_iface(struct<br>
> wpa_supplicant *wpa_s,<br>
><br>
> #ifdef CONFIG_P2P<br>
> wpa_s->conf_p2p_dev = os_rel2abs_path(iface-<br>
> >conf_p2p_dev);<br>
> +#ifndef ANDROID_P2P<br>
> wpa_config_read(wpa_s->conf_p2p_dev, wpa_s->conf);<br>
> +#endif<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">I think it would be cleaner to do the reading only if iface->p2p_mgmt is set (happens only in case a dedicated P2P DEVICE interface is added).<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</span><div><span class="">
<p class="MsoNormal">1) iface->p2p_mgmt will be set later.<u></u><u></u></p>
<p class="MsoNormal"><span style="color:rgb(31,73,125)"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">For the case of Non netdev P2P_DEVICE, iface->mgmt. is set in wpas_p2p_add_p2pdev_interface() and this is done before the flow that calls wpa_supplicant_add_iface()
-> wpa_supplicant_init_iface(), so using this state variable, the P2P specific configuration file would be read only for a (non netdev) P2P_DEVICE interface.</span></p></div></div></div></div></div></div></div></blockquote><div><br></div><div>Please correct me if I am wrong but <span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:15px">wpas_p2p_add_p2pdev_interface(</span><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:15px">)</span> is called after <span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:15px">wpa_supplicant_add_iface()</span></div><div><div style="font-family:'Courier New';font-size:10pt;color:rgb(0,0,0)">
<pre> wpa_s = <span style="font-weight:bolder">wpa_supplicant_add_iface</span>(global, &ifaces<span style="color:rgb(128,0,0)">[</span>i<span style="color:rgb(128,0,0)">]</span>);
<span style="color:rgb(128,0,128)">if</span> (wpa_s == <span style="color:rgb(192,64,0)">NULL</span>) <span style="color:rgb(128,0,0)">{</span>
exitcode = -<span style="color:rgb(0,0,128)">1</span>;
<span style="color:rgb(128,0,128)">break</span>;
<span style="color:rgb(128,0,0)">}</span>
<span style="color:rgb(128,128,0)">#ifdef</span> CONFIG_P2P
<span style="color:rgb(128,0,128)">if</span> (wpa_s->global->p2p == <span style="color:rgb(192,64,0)">NULL</span> &&
(wpa_s->drv_flags &
WPA_DRIVER_FLAGS_DEDICATED_P2P_DEVICE) &&
<span style="font-weight:bolder">wpas_p2p_add_p2pdev_interface</span>(wpa_s) < <span style="color:rgb(0,0,128)">0</span>)
exitcode = -<span style="color:rgb(0,0,128)">1</span>;
<span style="color:rgb(128,128,0)">#endif</span> <span style="color:rgb(0,128,0);font-style:italic">/* CONFIG_P2P */</span></pre></div></div><div>It is highly possible I am missing something but I am still can not fidn the case when we need to load -m switch file for main interface.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><div style="border-style:none none none solid;border-left-color:blue;border-left-width:1.5pt;padding:0cm 0cm 0cm 4pt"><div><div><div><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
</div><span class="">
<div>
<p class="MsoNormal">2) In case p2p has separate Netdev - it will have its own iterface, in case for Non-netdev it will still load this file<u></u><u></u></p>
</div>
</span><div><span class="">
<p class="MsoNormal">taking it from parent. Can you please describe the situation when we need to load this file for main interface?<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">In case that a P2P Device has a separate Netdev, you can simply use the –c to pass the configuration file for the interface with all needed parameters, so there
is no need to use the –m switch.</span></p></div></div></div></div></div></div></div></blockquote><div><br></div><div>Right, this is exactly my point.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><div style="border-style:none none none solid;border-left-color:blue;border-left-width:1.5pt;padding:0cm 0cm 0cm 4pt"><div><div><div><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">In the past Jouni wanted to better handle this by having some global configuration file that will hold global configuration parameters that would be shared
between all the interfaces. I tried to prepare some solution for this if (still in Jouni’s queue):<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><a href="http://patchwork.ozlabs.org/patch/332033/" target="_blank">http://patchwork.ozlabs.org/patch/332033/</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><a href="http://patchwork.ozlabs.org/patch/332034/" target="_blank">http://patchwork.ozlabs.org/patch/332034/</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><a href="http://patchwork.ozlabs.org/patch/332035/" target="_blank">http://patchwork.ozlabs.org/patch/332035/</a></span></p></div></div></div></div></div></div></div></blockquote><div><br></div><div>This is probably right thing to do but let's wait for Jouni's response.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><div style="border-style:none none none solid;border-left-color:blue;border-left-width:1.5pt;padding:0cm 0cm 0cm 4pt"><div><div><div><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Regards,<span class=""><font color="#888888"><u></u><u></u></font></span></span></p><span class=""><font color="#888888">
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Ilan.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
</font></span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div><br></div></div>