<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 9:32 AM, Rajkumar Manoharan <span dir="ltr"><<a href="mailto:rmanohar@qti.qualcomm.com" target="_blank">rmanohar@qti.qualcomm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Tue, May 06, 2014 at 08:02:49AM -0700, Paul Stewart wrote:<br>
> Hi Rajkumar! This functionality was originally added in order to allow<br>
> testing of OBSS functionality in clients of the AP. In particular, there<br>
> wasn't a built in stipulation that the AP hardware / firmware support OBSS<br>
> action frames. I don't mind having hostapd's default behavior being<br>
> predicated on the hardware being capable -- for example, you could set<br>
> obss_interval to 300 conditional on that hardware capability, but it would<br>
> be nice to preserve the ability to manually set this interval in the<br>
> configuration file regardless of the underlying hardware capability.<br>
><br>
</div>Paul,<br>
<br>
Still it allows the user to overwrite obss_interval manually by config_file.<br>
<div class=""><br>
> diff --git a/src/ap/ieee802_11_ht.c b/src/ap/ieee802_11_ht.c<br>
> index c0a7cd4..7020858 100644<br>
> --- a/src/ap/ieee802_11_ht.c<br>
> +++ b/src/ap/ieee802_11_ht.c<br>
> @@ -46,7 +46,8 @@ u8 * hostapd_eid_ht_capabilities(struct hostapd_data<br>
> *hapd, u8 *eid)<br>
><br>
> pos += sizeof(*cap);<br>
><br>
> - if (hapd->iconf->obss_interval) {<br>
> + if (hapd->iconf->obss_interval &&<br>
> + (hapd->iface->drv_flags & WPA_DRIVER_FLAGS_HT_2040_COEX)) {<br></div></blockquote><div><br></div><div>This is an example of the concern I was bringing up. This conditional will trigger only if the driver flags contain WPA_DRIVER_FLAGS_HT_2040_COEX. I'd like to be able to include this IE for testing purposes even if the driver doesn't support this flag.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">
> struct ieee80211_obss_scan_parameters *scan_params;<br>
><br>
<br>
</div>Since AP side functionalities are recently added, OBSS scan trigger<br>
interval is assigned with default and obss IE will be appended in beacon/probe resp<br>
based on driver capabilities. Earlier the OBSS IE is added if obss_interval is<br>
non-zero eventhough the driver does not support OBSS funtionalities.<br>
<br>
Both station and AP mode 20/40 coex functionalities are validated in ath9k driver.<br>
<span class=""><font color="#888888"><br>
-Rajkumar<br>
</font></span><div class=""><div class="h5">_______________________________________________<br>
HostAP mailing list<br>
<a href="mailto:HostAP@lists.shmoo.com">HostAP@lists.shmoo.com</a><br>
<a href="http://lists.shmoo.com/mailman/listinfo/hostap" target="_blank">http://lists.shmoo.com/mailman/listinfo/hostap</a><br>
</div></div></blockquote></div><br></div></div>