<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 24, 2014 at 5:20 PM, Jouni Malinen <span dir="ltr"><<a href="mailto:j@w1.fi" target="_blank">j@w1.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">On Mon, Feb 24, 2014 at 11:46:53AM -0400, Eduardo Abinader wrote:<br>
> This patch aims to fix the update of current symbolic link,<br>
> when LOGDIR is already set. The current symbolic link was only<br>
> set, if LOGDIR has not been previously defined. If the user<br>
> had chosen to cancel the running test and run it again, the current<br>
> symbolic link was not being updated.<br>
<br></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
</div>What do you mean with canceling a running test? For me, that means<br>
stopping and restarting run-tests.py, so I'm not completely sure I<br>
understood what the problem would be since start.sh would not be even<br>
run again in that case..<br>
<br></blockquote><div>I meant: ./run-all.sh --> ctrl+c ---> ./run-all.sh <br><br></div><div>start.sh is invoked and current is not updated. <br><br>You may also try ./run-all.sh --> ctrl+c and then:<br> ./start.sh<br>
</div><div>./run-test.py -f <test><br><br></div><div>Current symbolic is not updated also. Thus, this patch fixes this issue.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> diff --git a/tests/hwsim/start.sh b/tests/hwsim/start.sh<br>
<div class="">> @@ -7,13 +7,11 @@ HAPD=$DIR/../../hostapd/hostapd<br>
</div><div class="">> +DATE="$(date +%s)"<br>
><br>
> if [ -z "$LOGDIR" ] ; then<br>
> - DATE="$(date +%s)"<br>
> LOGDIR="$DIR/logs/$DATE"<br>
> mkdir -p $LOGDIR<br>
> - rm -rf $DIR/logs/current<br>
> - ln -sf $DATE $DIR/logs/current<br>
> else<br>
> if [ -e $LOGDIR/alt-wpa_supplicant/wpa_supplicant/wpa_supplicant ]; then<br>
> WPAS=$LOGDIR/alt-wpa_supplicant/wpa_supplicant/wpa_supplicant<br>
> @@ -29,6 +27,9 @@ else<br>
</div><div class="">> +rm -rf $DIR/logs/current<br>
> +ln -sf $DATE $DIR/logs/current<br>
<br>
</div>This adds an undesired error message for vm-run.sh cases since $DIR/logs<br>
directory is on a read-only file system within the VM. That's one of the<br>
main reasons why the existing code is within that if branch.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>Ok, I managed to fix this misbehavior. I'm now sending the the proper patch.<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">
--<br>
Jouni Malinen PGP id EFC895FA<br>
_______________________________________________<br>
HostAP mailing list<br>
<a href="mailto:HostAP@lists.shmoo.com">HostAP@lists.shmoo.com</a><br>
<a href="http://lists.shmoo.com/mailman/listinfo/hostap" target="_blank">http://lists.shmoo.com/mailman/listinfo/hostap</a><br>
</font></span></blockquote></div><br></div></div>