<br><div><div class="gmail_quote">On Wed, Mar 20, 2013 at 2:21 AM, Arend van Spriel <span dir="ltr"><<a href="mailto:arend@broadcom.com" target="_blank">arend@broadcom.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 03/19/2013 09:35 PM, Jan Ceuleers wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
One review comment below.<br>
<br>
On 03/19/2013 08:26 AM, Chaitanya TK wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
As per P2P-sec V1.2: "The P2P Group<br>
Info attribute shall be omitted if there are zero<br>
connected P2P Clients."<br>
<br>
Don't add the IE, if the no of peers are zero.<br>
<br>
Signed-off-by: T Krushna Chaitanya <<a href="mailto:chaitanyatk@posedge.com" target="_blank">chaitanyatk@posedge.com</a>><br>
</blockquote></blockquote>
<br></div>
Should be: Signed-hostap:<br>
<br>
See CONTRIBUTIONS file.<br></blockquote><div><br></div><font color="#000099"><font face="courier new,monospace">Will resend the patch with signed-off changed.</font></font><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also the email address does not match the gmail address you used to send it. Not sure if that is acceptable.</blockquote><div><br></div><div><span style="font-family:'courier new',monospace;color:rgb(0,0,153)">The problem with the email is that i want to store all</span></div>
<div><font color="#000099"><font face="courier new,monospace">the group emails to my gmail for future use but as we</font></font></div><div><font color="#000099"><font face="courier new,monospace">cant use gmail to send patches (line wrapping and whitespace</font></font></div>
<div><font color="#000099"><font face="courier new,monospace">issues) i used my official email(uses thuderbird) </font></font></div><div><font color="#000099"><font face="courier new,monospace">which is not registered, so i use SMTP of gmail through </font></font></div>
<div><span style="color:rgb(0,0,153);font-family:'courier new',monospace">thunderbird causing the confusion.</span> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
<br>
src/p2p/p2p_group.c | 16 +++++++++-------<br>
1 files changed, 9 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/src/p2p/p2p_group.c b/src/p2p/p2p_group.c<br>
index 9559e44..7adab90 100644<br>
--- a/src/p2p/p2p_group.c<br>
+++ b/src/p2p/p2p_group.c<br>
@@ -413,14 +413,16 @@ static struct wpabuf * p2p_group_build_probe_resp_ie(<u></u>struct p2p_group *group)<br>
/* P2P Device Info */<br>
p2p_buf_add_device_info(p2p_<u></u>subelems, group->p2p, NULL);<br>
<br>
- /* P2P Group Info */<br>
- group_info = wpabuf_put(p2p_subelems, 0);<br>
- wpabuf_put_u8(p2p_subelems, P2P_ATTR_GROUP_INFO);<br>
- wpabuf_put_le16(p2p_subelems, 0); /* Length to be filled */<br>
- for (m = group->members; m; m = m->next)<br>
- p2p_client_info(p2p_subelems, m);<br>
- WPA_PUT_LE16(group_info + 1,<br>
+ /* P2P Group Info: Only when at least 1 P2P CLI is connected */<br>
+ if (group->members != 0) {<br>
+ group_info = wpabuf_put(p2p_subelems, 0);<br>
+ wpabuf_put_u8(p2p_subelems, P2P_ATTR_GROUP_INFO);<br>
+ wpabuf_put_le16(p2p_subelems, 0); /* Length to be filled */<br>
+ for (m = group->members; m; m = m->next)<br>
+ p2p_client_info(p2p_subelems, m);<br>
+ WPA_PUT_LE16(group_info + 1,<br>
(u8 *) wpabuf_put(p2p_subelems, 0) - group_info - 3);<br>
</blockquote>
<br>
Purely based on visual inspection I rather suspect that there should be<br>
a "+" at the beginning of the above line.<br>
<br>
How did you generate this patch?<br>
<br>
</blockquote>
<br></div></div>
Might be an email client issue.<br></blockquote><div> </div><div><font color="#000099"><font face="courier new,monospace">I have used git diff to generate t</font></font><span style="font-family:'courier new',monospace;color:rgb(0,0,153)">he patch, let</span></div>
<div><span style="font-family:'courier new',monospace;color:rgb(0,0,153)">me check the issue with that line.</span> </div></div></div>