<div dir="ltr"><div class="gmail_default" style>I considered wpas_select_network_from_last_scan(), but I wondered whether the calls to wpa_supplicant_rsn_preauth_scan_results on old scan results or everything in the "else" clause for "if (selected)" was valid in this case. If you're okay with a hard-coded time limit like interworking_reconnect, I can do that. Also let me know if you're unconcerned by any side effects the rest of wpas_select_network_from_last_scan().</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 16, 2013 at 1:47 AM, Jouni Malinen <span dir="ltr"><<a href="mailto:j@w1.fi" target="_blank">j@w1.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tue, Jan 15, 2013 at 06:28:09PM -0800, Paul Stewart wrote:<br>
> If scan results are available when we perform a SelectNetwork, use<br>
> them to make an associate decision. This can save an entire scan<br>
> interval-worth of time in situations where something external to<br>
> wpa_supplicant (like a connection manager) has just previously<br>
> requested a scan before calling SelectNetwork.<br>
<br>
</div>interworking_reconnect() does this conditionally on how old the previous<br>
scan results are and by re-using the<br>
wpas_select_network_from_last_scan() function. Is there reason to have<br>
SelectNetwork behave differently? In other words, could this new<br>
wpa_supplicant_fast_associate() be replaced with a call to the existing<br>
wpas_select_network_from_last_scan()? I would also consider adding some<br>
time limit based on wpa_s->last_scan. Five seconds may be a bit too<br>
short for this, but using three minutes old results does not sound that<br>
good either.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Jouni Malinen PGP id EFC895FA<br>
_______________________________________________<br>
HostAP mailing list<br>
<a href="mailto:HostAP@lists.shmoo.com">HostAP@lists.shmoo.com</a><br>
<a href="http://lists.shmoo.com/mailman/listinfo/hostap" target="_blank">http://lists.shmoo.com/mailman/listinfo/hostap</a><br>
</font></span></blockquote></div><br></div>