<p dir="ltr">M</p>
<div class="gmail_quote">On Apr 16, 2012 3:22 PM, "Jouni Malinen" <<a href="mailto:j@w1.fi">j@w1.fi</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Mon, Apr 09, 2012 at 12:44:54PM +0530, Jithu Jance wrote:<br>
> Regarding the patch, do we really need to iterate through the interface<br>
> list?. I was assuming that the wpas_drv_shared_freq implementation should<br>
> take care of this.In case of virtual interfaces sharing a single PHY, the<br>
> shared_freq handler should return the freq in use (STA associated freq/ GO<br>
> operating freq).<br>
<br>
The initial design of shared_freq() was really to use it only for the<br>
case where there are virtual interfaces controlled by something else<br>
than the current wpa_supplicant process (e.g., another wpa_supplicant<br>
process or something completely different in case where P2P support is<br>
managed by wpa_supplicant but a legacy station interface is run by<br>
another software component). For driver_nl80211.c, my assumption was<br>
that the same wpa_supplicant process would be used and as such, the<br>
expectation was that shared_freq() would not actually be needed at all..<br>
<br>
While there is now shared_freq() in driveR_nl80211.c, I'm not sure I<br>
would really like to drop the concept of being able to figure out this<br>
type of details through iteration of the internal data structure in the<br>
core wpa_supplicant implementation.<br>
<br>
> Again, this iteration check would be required for drivers which doesn't<br>
> implement the shared_freq handler and still have shared virtual interfaces<br>
> over a single PHY. I may be missing something here also. Please correct my<br>
> understanding, if wrong. Apart from this doubt, everything else looks fine<br>
> with the cleaned up version of the patch.<br>
<br>
Well, that was the original assumption for driver_nl80211.c..<br>
<br>
--<br>
Jouni Malinen PGP id EFC895FA<br>
_______________________________________________<br>
HostAP mailing list<br>
<a href="mailto:HostAP@lists.shmoo.com">HostAP@lists.shmoo.com</a><br>
<a href="http://lists.shmoo.com/mailman/listinfo/hostap" target="_blank">http://lists.shmoo.com/mailman/listinfo/hostap</a><br>
</blockquote></div>