On Wed, Jan 4, 2012 at 3:12 PM, Dan Williams <<a href="mailto:dcbw@redhat.com">dcbw@redhat.com</a>> wrote:<br>> On Wed, 2012-01-04 at 14:37 -0800, Grant Erickson wrote:<br>>> This allows the package build to specify the D-Bus version being built<br>
>> against externally to pkg-config.<br>><br>> What does this actually do? I don't see DBUS_VERSION actually used<br>> anywhere in the wpa_supplicant code or makefiles, nor is it used in the<br>> D-Bus headers. Perhaps we should just remove those pieces?<br>
<br>Dan,<br><br>I've no idea what the intent originally was or what it is supposed to do today.<div><br></div><div>Searching through existing packages in my current project indicates that avahi is doing something similar and has some conditional code based on the extracted major and minor values:<br>
<br><div>% grep -ri 'DBUS_VERSION\(_MAJOR\|_MINOR\)' avahi/ connman/ dbus/ hostap/ libnih/ upstart/ | files -su</div><div>avahi/avahi-0.6.28/avahi-common/dbus-watch-glue.c</div><div>avahi/avahi-0.6.28/avahi-daemon/dbus-protocol.c</div>
<div>avahi/avahi-0.6.28/configure</div><div>avahi/avahi-0.6.28/<a href="http://configure.ac">configure.ac</a></div><div>hostap/hostap/wpa_supplicant/Android.mk</div><div>hostap/hostap/wpa_supplicant/dbus/Makefile</div><div>
hostap/hostap/wpa_supplicant/Makefile</div><div><br></div><div>However, beyond the cited make files, hostap does nothing with them nor does D-Bus itself.</div><div><br></div><div>That said, I am OK with getting rid of the checks altogether.</div>
<div><br></div><div>-Grant</div></div>