How do you perform both Broadcast and directed scan over channels at the same time?<div>For example, when looking for a network to join, including some hidden SSIDs.</div><div><br></div><div>-Dan<br><br><div class="gmail_quote">
On Wed, Oct 6, 2010 at 11:06 PM, Dan Williams <span dir="ltr"><<a href="mailto:dcbw@redhat.com">dcbw@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Wed, 2010-10-06 at 15:46 -0700, Daniel Kurtz wrote:<br>
> This patch changes wpa_supplicant policy for handling '' in SSIDs field of Interface.SSID DBus message.<br>
> It treats '' (zero-length) SSID as a request for a broadcast scan, instead of ignoring it.<br>
<br>
</div>Does not sending any SSIDs somehow not work? This seems like a pretty<br>
big kludge. The behavior should be that if no SSID property is sent,<br>
then no specific scan is performed. A zero-length SSID should actually<br>
be rejected with an error.<br>
<font color="#888888"><br>
Dan<br>
</font><div><div></div><div class="h5"><br>
> This patch updates DBus API .Scan() logic per the test cases listed below:<br>
><br>
> 1) Interface.Scan({'Type':'active', 'Channel':(2412, 20)})<br>
> Request: Active scan with only '' SSID (1 channel)<br>
> Should be: 1 broadcast ProbeRequest on specified channel<br>
> Previous: 1 broadcast ProbeRequest on specified channel<br>
> This Patch: 1 broadcast ProbeRequest on specified channel<br>
><br>
> 2) Interface.Scan({'Type':'active', 'Channel':(2412, 20), 'SSIDs':['']})<br>
> Request: Active scan with only '' SSID (1 channel)<br>
> Should be: 1 broadcast ProbeRequest on specified channel<br>
> Previous: No ProbeRequests; passive scan results for specified channel<br>
> This Patch: FIXED: 1 broadcast ProbeRequest on specified channel<br>
><br>
> 3) Interface.Scan({'Type':'active', 'Channel':(2412, 20), 'SSIDs':['MySSID']})<br>
> Request: Active scan with only non-'' SSIDs (1 channel)<br>
> Should be: 1 directed ProbeRequest for each SSID on specified channel, no broadcast ProbeRequest<br>
> Previous: 1 directed ProbeRequest for each SSID on specified channel, no broadcast ProbeRequest<br>
> This Patch: 1 directed ProbeRequest for each SSID on specified channel, no broadcast ProbeRequest<br>
><br>
> 4) Interface.Scan({'Type':'active', 'Channel':(2412, 20), 'SSIDs':['', 'MySSID']})<br>
> Request: Active scan with SSIDs, including 1 '' SSID (1 channel)<br>
> Should be: 1 broadcast ProbeRequest, 1 directed ProbeRequest for each non-'' SSID on specified channel<br>
> Previous: 1 directed ProbeRequest for each non-'' SSID on specified channel<br>
> This Patch: FIXED: 1 broadcast ProbeRequest, 1 directed ProbeRequest for each non-'' SSID on specified channel<br>
> ---<br>
> wpa_supplicant/dbus/dbus_new_handlers.c | 30 +++++++++++++++++-------------<br>
> 1 files changed, 17 insertions(+), 13 deletions(-)<br>
><br>
> diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c<br>
> index e2b5e50..36eb917 100644<br>
> --- a/wpa_supplicant/dbus/dbus_new_handlers.c<br>
> +++ b/wpa_supplicant/dbus/dbus_new_handlers.c<br>
> @@ -987,21 +987,25 @@ static int wpas_dbus_get_scan_ssids(DBusMessage *message, DBusMessageIter *var,<br>
> dbus_message_iter_recurse(&array_iter, &sub_array_iter);<br>
><br>
> dbus_message_iter_get_fixed_array(&sub_array_iter, &val, &len);<br>
> - if (len == 0) {<br>
> - dbus_message_iter_next(&array_iter);<br>
> - continue;<br>
> - }<br>
><br>
> - ssid = os_malloc(len);<br>
> - if (ssid == NULL) {<br>
> - wpa_printf(MSG_DEBUG, "wpas_dbus_handler_scan[dbus]: "<br>
> - "out of memory. Cannot allocate memory for "<br>
> - "SSID");<br>
> - *reply = dbus_message_new_error(<br>
> - message, DBUS_ERROR_NO_MEMORY, NULL);<br>
> - return -1;<br>
> + if (len != 0) {<br>
> + ssid = os_malloc(len);<br>
> + if (ssid == NULL) {<br>
> + wpa_printf(MSG_DEBUG,<br>
> + "wpas_dbus_handler_scan[dbus]: "<br>
> + "out of memory. Cannot allocate "<br>
> + "memory for SSID");<br>
> + *reply = dbus_message_new_error(<br>
> + message, DBUS_ERROR_NO_MEMORY,<br>
> + NULL);<br>
> + return -1;<br>
> + }<br>
> + os_memcpy(ssid, val, len);<br>
> + } else {<br>
> + /* Allow zero-length SSIDs */<br>
> + ssid = NULL;<br>
> }<br>
> - os_memcpy(ssid, val, len);<br>
> +<br>
> ssids[ssids_num].ssid = ssid;<br>
> ssids[ssids_num].ssid_len = len;<br>
><br>
<br>
<br>
</div></div></blockquote></div><br></div>