[PATCH] Removing redundant commands in wpa_cli

Jouni Malinen j at w1.fi
Fri Mar 27 09:30:29 EDT 2015


On Fri, Mar 27, 2015 at 12:36:04PM +0100, Ola Olsson wrote:
> Fair enough, I see your point. I am not sure about your view regarding
> backward compatibility though, but I'll include a new patch removing the
> commands in wpa_supplicant as well. Use it if you want.

Thanks, this patch would be more consistent way of removing these.

In general, I try to avoid removing any control interface commands that
may be in identifiable or expected use unless there is a very strong
justification for doing that (e.g., some issues with the specific
command that cannot be fixed without doing incompatible changes).

This patch is removing the following commands:
BSS_EXPIRE_AGE
BSS_EXPIRE_COUNT
AP_SCAN

I'm not aware of BSS_EXPIRE_* users. Those were added to the control
interface with matching changes in the D-Bus interface and my
interpretation there was that the D-Bus interface would have been used
for the specific use case.

I do know that AP_SCAN has been used. It was used in Android until 4.2,
i.e., it was removed in 4.3 in this commit:
https://android.googlesource.com/platform/frameworks/base/+/bcc97ca43a339c3356b5c8d9eaf1cbdfb0de3165

As far as Android is concerned, I'm trying to maintain support for last
couple of AOSP releases which I'd say would be 4.4, 5.0, and 5.1 at the
moment. As such, it may be justifiable to remove AP_SCAN from Android
view point.


If anyone happens to be aware of any other uses of these three
wpa_supplicant control interface commands, please let me know. I'm not
applying this patch now, but I may apply it later if no real users for
the commands can be identified.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list