[PATCH 2/5] p2p: update dialog_token on failures as well

Eliad Peller eliad at wizery.com
Mon Mar 23 04:34:47 EDT 2015


On Mon, Mar 23, 2015 at 10:28 AM, Jouni Malinen <j at w1.fi> wrote:
> On Mon, Mar 23, 2015 at 10:19:41AM +0200, Eliad Peller wrote:
>> i thought it makes sense to always make the dialog token unique
>> (per-device) and incrementing.
>
> Why?
>
>> i guess it's also relevant for the
>> P2P_SC_FAIL_INFO_CURRENTLY_UNAVAILABLE case, where a new GO
>> Negotiation might be attempted, while reusing the the dialog token.
>
> Please provide more details on this and ideally a debug log showing the
> benefit.
>
> This is an area that has risk for interoperability issues and I don't
> really want to change anything in the externally visible behavior
> without a good justification on why such a change would be needed.
>
ok. so please drop it for now.
i'm not sure there is an actual error here.
i'll re-send it (with logs) in case i'll encounter any actual issue.

Eliad.


More information about the HostAP mailing list