[PATCH 2/5] p2p: update dialog_token on failures as well

Eliad Peller eliad at wizery.com
Mon Mar 23 04:19:41 EDT 2015


On Sun, Mar 22, 2015 at 7:11 PM, Jouni Malinen <j at w1.fi> wrote:
> On Sun, Mar 22, 2015 at 11:58:26AM +0200, Eliad Peller wrote:
>> On Fri, Mar 20, 2015 at 3:18 PM, Jouni Malinen <j at w1.fi> wrote:
>> > Could you please clarify what this solves and which frame would be the
>> > target for preventing the same dialog token from being used again? The
>> > change here is in p2p_process_go_neg_req() and that function does not
>> > verify dialog_token matching (only GO Neg Resp and Conf has such code as
>> > far as GO Negotiation is concerned).
>> >
>> this doesn't solve any specific scenario, but just seems like the
>> right thing to do in order to prevent the same dialog token from being
>> reused (e.g. when sending a new provision discovery).
>
> Provision Discovery? Why would take make any difference? The dialog
> token is specific to each request/response(/confirm) transaction for a
> specific type of frames; it does not have any meaning between GO
> Negotiation frames and Provision Discovery frames. If fetching a dialog
> token from a GO Negotiation frame and then using that dialog token in a
> Provision Discovery frame is the intent here, I don't see why that would
> be of any benefit.
>
i thought it makes sense to always make the dialog token unique
(per-device) and incrementing.
i guess it's also relevant for the
P2P_SC_FAIL_INFO_CURRENTLY_UNAVAILABLE case, where a new GO
Negotiation might be attempted, while reusing the the dialog token.

Eliad.


More information about the HostAP mailing list