[PATCH] P2P: Use default driver GO WMM PS capabilities

Peer, Ilan ilan.peer at intel.com
Mon Mar 23 02:48:36 EDT 2015


> -----Original Message-----
> From: hostap-bounces at lists.shmoo.com [mailto:hostap-
> bounces at lists.shmoo.com] On Behalf Of Jouni Malinen
> Sent: Sunday, March 22, 2015 21:54
> To: hostap at lists.shmoo.com
> Subject: Re: [PATCH] P2P: Use default driver GO WMM PS capabilities
> 
> On Mon, Mar 16, 2015 at 01:20:49AM -0400, Ilan Peer wrote:
> > By default, use the driver flags to determine weather to enable GO WMM
> > PS or not.
> 
> > diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c @@ -572,7
> > +572,7 @@ int wpa_supplicant_create_ap(struct wpa_supplicant *wpa_s,
> >  	else if (params.p2p && (wpa_s->drv_flags &
> WPA_DRIVER_FLAGS_AP_UAPSD))
> >  		params.uapsd = 1; /* mandatory for P2P GO */
> >  	else
> > -		params.uapsd = -1;
> > +		params.uapsd = !!(wpa_s->drv_flags &
> WPA_DRIVER_FLAGS_AP_UAPSD);
> 
> This does not seems to do much for GO since params.p2p == 1 for that case
> and that case is already setting params.uapsd to 1 if the driver supports this. In
> other words, this change would change only non-P2P AP behavior and
> potentially P2P GO with a driver that does not support U-APSD (though, that
> change from -1 to 0 would not really have much of a difference). In other
> words, I don't think this is doing what the commit message claims this to do..
> Furthermore, I don't think I'd like to unconditionally enable U-APSD for non-
> P2P cases.
> 

Sorry for this. This is an old patch that I forgot to send ... and I sent it now without checking if it is still relevant.

Ilan.





More information about the HostAP mailing list