[PATCH 2/5] p2p: update dialog_token on failures as well

Eliad Peller eliad at wizery.com
Sun Mar 22 05:58:26 EDT 2015


hi Jouni,

On Fri, Mar 20, 2015 at 3:18 PM, Jouni Malinen <j at w1.fi> wrote:
> On Thu, Mar 19, 2015 at 04:41:40PM +0200, Eliad Peller wrote:
>> Update the dialog token even when GO negotiation
>> failed, in order prevent the same dialog token
>> from being used again.
>
> Could you please clarify what this solves and which frame would be the
> target for preventing the same dialog token from being used again? The
> change here is in p2p_process_go_neg_req() and that function does not
> verify dialog_token matching (only GO Neg Resp and Conf has such code as
> far as GO Negotiation is concerned).
>
this doesn't solve any specific scenario, but just seems like the
right thing to do in order to prevent the same dialog token from being
reused (e.g. when sending a new provision discovery).

Eliad.


More information about the HostAP mailing list