[PATCH 1/2] P2P: improve deinit for go neg non-zero status

Jouni Malinen j at w1.fi
Sat Mar 7 14:38:49 EST 2015


On Mon, May 12, 2014 at 01:21:04PM -0400, Eduardo Abinader wrote:
> >> > > @@ -1590,6 +1590,8 @@ static void wpas_go_neg_completed(void *ctx, struct p2p_go_neg_results *res)
> >> > >                              res->status);
> >> > >               wpas_notify_p2p_go_neg_completed(wpa_s, res);
> >> > >               wpas_p2p_remove_pending_group_interface(wpa_s);
> >> > > +             eloop_cancel_timeout(wpas_p2p_long_listen_timeout, wpa_s, NULL);
> >> > > +             wpas_p2p_group_formation_failed(wpa_s);
> >> > >               return;
> >> > >       }

> Actually, it depends on the scenario. I have faced issues with wps
> pbc, where timeout is being set.

> p2p_group_formation_failed for this particular case, 4-way handshake
> is not completed, and status is non-zero, it speeds up the deauth. It
> acutally does: I got 4 to 5 seconds faster.

I have tried to understand this couple of times, but always have ended
up giving up and leaving the patch in the queue to find a better time to
look a this.. Now that I'm trying to clean all the pending items, I
cannot really follow this explanation at all.. This function is
wpas_go_neg_complete(). It is called at the completion of GO Negotiation
which happens before there is any chance of even starting WPS PBC. As
such, this does not really make any sense to me.

If there is a case where this change is needed, please provide
wpa_supplicant debug logs with and without this change pointing out the
improvement. For now, I'll drop this patch and the 2/2 cleanup.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list