p2p_mgmt interface and tdls_init
Arend van Spriel
arend at broadcom.com
Thu Jun 25 13:02:29 EDT 2015
On 06/25/15 17:10, Krishna Chaitanya wrote:
> On Thu, Jun 25, 2015 at 8:21 PM, Arend van Spriel<arend at broadcom.com> wrote:
>> On 06/25/15 16:47, Arend van Spriel wrote:
>>> On 06/25/15 16:21, Krishna Chaitanya wrote:
>>>> I wanted to know the reason for blocking TDLS L2 Packet registration
>>>> if the driver doesn't support
>>>> dedicated p2p interface.
>>>> this was introduced in this commit
>>> The intention was to block it for the dedicated p2p interface as it is
>>> not transporting data and looking at the patch it is doing that, but I
>>> might be wrong.
>> Looking at it again I support "dedicated p2p interface" is not same as P2P
>> device interface. The patch avoids l2 for both, but for "dedicated p2p
>> interface" it was already true before this patch. But the flag is a driver
>> flag so not sure if that is a correct check.
> Currently the check is as below: It checks for both DRIVER capability
> and adding p2p_dev interface.
> #ifdef CONFIG_TDLS
> if ((!iface->p2p_mgmt ||
> return -1;
> #endif /* CONFIG_TDLS */
> So is my understanding, this check is to avoid
> registering for EAPOL/TDLS framesfor P2P_DEV interface, correct?
Correct. The above deals with TDLS part although the check for drv_flags
was not in my patch. I think it is allow tdls operation for non-p2pdev
interface that is assigned to be used for p2p mgmt. Below fragment deals
with EAPOL (if not mistaken):
diff --git a/wpa_supplicant/wpa_supplicant.c
index ea2d06b..0fa794d 100644
@@ -2327,7 +2327,8 @@ int wpa_supplicant_update_mac_addr(struct
const u8 *addr = wpa_drv_get_mac_addr(wpa_s);
os_memcpy(wpa_s->own_addr, addr, ETH_ALEN);
- } else if (!(wpa_s->drv_flags &
+ } else if (!wpa_s->p2p_mgmt &&
+ !(wpa_s->drv_flags &
wpa_s->l2 = l2_packet_init(wpa_s->ifname,
More information about the HostAP