[PATCH 6/9] P2P: Relax the conditions that allow cross-connection

Peer, Ilan ilan.peer at intel.com
Sun Jun 21 13:54:11 EDT 2015


Hi Jouni,

> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Friday, June 19, 2015 16:15
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com
> Subject: Re: [PATCH 6/9] P2P: Relax the conditions that allow cross-
> connection
> 
> On Wed, Jun 17, 2015 at 04:18:18PM +0300, Ilan Peer wrote:
> > Change the conditions that allow a cross connection to allow all the
> > interface shared by the same radio, and not only the parent interface.
> 
> The current implementation does not limit this to interfaces shared by the
> same radio. Why would there be such restriction?
> 
> > diff --git a/wpa_supplicant/p2p_supplicant.c
> > b/wpa_supplicant/p2p_supplicant.c @@ -6729,14 +6729,16 @@ static void
> wpas_p2p_cross_connect_setup(struct wpa_supplicant *wpa_s)
> > -	for (iface = wpa_s->global->ifaces; iface; iface = iface->next) {
> > +	dl_list_for_each(iface, &wpa_s->radio->ifaces, struct wpa_supplicant,
> > +			 radio_list) {
> 
> Unless I'm missing something here, this would break the case where the
> device has two radios, one for P2P and the other one for non-P2P use.
> P2P cross connection should be possible with such a non-P2P station
> interface on another radio.
> 

My bad ... I never practiced having a single wpa_supplicant controlling several devices :)
Will fix this so for P2P capable driver I'll iterate all the radio interfaces and not only the parent.

Thanks,

Ilan.


More information about the HostAP mailing list