[PATCH 9/9] TDLS: return channel-switch indication in link status cmd

Jouni Malinen j at w1.fi
Fri Jun 19 09:29:33 EDT 2015


On Wed, Jun 17, 2015 at 04:18:21PM +0300, Ilan Peer wrote:
> Return an appropriate indication in the tdls_get_link_status command when
> when channel switching is enabled for the TDLS peer.

> diff --git a/src/rsn_supp/tdls.c b/src/rsn_supp/tdls.c
> @@ -902,6 +902,9 @@ const char * wpa_tdls_get_link_status(struct wpa_sm *sm, const u8 *addr)
>  	if (!peer->tpk_success)
>  		return "peer not connected";
>  
> +	if (peer->chan_switch_enabled)
> +		return "connected/channel-switching";
> +
>  	return "connected";

This would change control interface TDLS_LINK_STATUS output. Couldn't
that break existing users of the interface?

Why would the link status indicate whether channel switching has been
enabled? This does not necessarily mean that channel switching is in use
(i.e., up to the driver to decide whether to use that or not). What
would upper layer programs do with this information?

Another possibility could be to add another line into the
TDLS_LINK_STATUS output so that the current "TDLS link status: <value>"
values would not change for the "connected" case. I'm not sure how much
more likely external users would be able to parse this, but at least the
current output looks like something that could be followed by other
lines of information.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list