[PATCH 0/5] Static analysis fixes

Jouni Malinen j at w1.fi
Thu Jun 18 18:44:03 EDT 2015


On Wed, Jun 17, 2015 at 04:16:31PM +0300, Ilan Peer wrote:
> Ben Rosenfeld (3):
>   wpa_supplicant: Fix possible memory leak in openssl_tls_prf()
>   P2P: Fix possible memory leak in p2p_process_nfc_connection_handover()

Thanks, applied those two (patches 3 and 4).

>   WPS: Fix possible memory leak in wps_er_config_token_from_cred()
> 
> Eytan Lifshitz (2):
>   wpa_supplicant: fix possible memory leak in handle_auth()
>   wpa_supplicant: fix possible memory leak

I don't see how these could be hit in practice and the proposed changes
seem to make the implementation more difficult to understand. As such,
I'm planning on dropping these unless someone can identify a case where
the memory leak could happen at least theoretically.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list