[PATCH 18/19] P2PS: add a wildcard with other advertised service info

Jouni Malinen j at w1.fi
Thu Jun 18 07:01:08 EDT 2015


On Wed, Jun 10, 2015 at 11:43:48AM +0300, Ilan Peer wrote:
> Quoting WFDS spec: "If multiple Service Hash values are included in the
> Probe Request frame the ASP shall find a match for each Service Hash,
> and it shall send a Probe Response frame with the information listed for
> all matched Service Hashes." This patch changes a handling of a wildcard
> hash matching by adding a wildcard 'org.wi-fi.wfds' info together with other
> hash matches.

Could you please clarify what kind of use case would use both the
wildcard hash and a specific hash in a single request? How is that
different from including just the wildcard hash? Would it be better to
provide all services (if there is enough room in the frame) as a
response if wildcard hash is included in the request?

> @@ -573,6 +571,13 @@ void p2p_buf_add_service_instance(struct wpabuf *buf, struct p2p_data *p2p,
>  	/* add advertised service info of matching services */
>  	for (adv = adv_list; adv && total_len <= MAX_SVC_ADV_LEN;
>  	     adv = adv->next) {

I.e., this loop could replace the exact hash match with "if
wildcard-was-included OR exact hash match".

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list