[PATCH 0/9] P2PS fix for PIN handling and test modifications

Jouni Malinen j at w1.fi
Fri Jul 10 13:03:43 EDT 2015


On Thu, Jul 02, 2015 at 04:14:51PM +0300, Ilan Peer wrote:
> While running WFDS certification tests, we've identified a bug in the way
> the P2PS P2P-PROV-SHOW-PIN/P2P-PROV-ENTER-PIN where handled in the
> wpa_supplicant.
> 
> The first patch in the set fixes this to behave as expected by the WFDS
> specification. The fix caused some of the P2PS tests to fail as they
> did not adhere to the WFDS specification.
> 
> The following patches in the set fix some issues identified during testing
> and in addition re-factor the p2ps tests by adding a generic methods for p2ps
> provision and connection establishments. These methods make more strict
> validation of the expected p2ps flows and reused in all the p2ps tests,
> which simplifies the existing tests and makes easier adding new ones.

Are all the test cases expected to pass after this full set of patches?
I'm trying to get this into working state before pushing in the changes,
but two test cases seem to be failing consistently:

START p2ps_connect_p2ps_method_2 1/2
Exception: P2P-GROUP-STARTED timeout on 02:00:00:00:00:00
FAIL p2ps_connect_p2ps_method_2 11.063686 2015-07-10 16:53:13.534868
START p2ps_connect_p2ps_method_4 2/2
Exception: P2P-GROUP-STARTED timeout on 02:00:00:00:00:00
FAIL p2ps_connect_p2ps_method_4 11.461259 2015-07-10 16:53:25.382879
failed tests: p2ps_connect_p2ps_method_2 p2ps_connect_p2ps_method_4

This is the set of patches that I had in my work branch when running
these tests:

http://w1.fi/p/p2ps-pd-pin-event/

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list