[PATCH v2] Adding disassociate reason as property in dbus

Jouni Malinen j at w1.fi
Tue Jul 7 12:35:45 EDT 2015


On Tue, Jul 07, 2015 at 10:45:55AM -0500, Dan Williams wrote:
> Would you like the patch more if it *also* showed the reason for a
> disassociation from associated state?  I'd say there's a case for
> both...

I don't know what the use case is for this new property change signal
(which, I'd assume, is the goal here.. getting out a D-Bus signal on
some specific events related to connection status) and as such,
including the disassociation case does not make any difference to me as
long as there are conflicts between the documentation and
implementation. If the commit message (and the D-Bus property name) were
to accurately describe what thisbeing done and what it is useful for, I
would have no issues with either of these cases.

Please keep in mind that disassociation happens only if there was an
association and the association reject event indicates that the attempt
to associate was rejected. These are very different cases from the view
point of association/disassociation management frames.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list