[PATCH 15/15] supplicant: Add state transition timestamps.

[Ben Greear]

On 01/31/2015 03:15 PM, Jouni Malinen wrote:
> On Wed, Mar 05, 2014 at 04:20:00PM -0800, greearb at candelatech.com wrote:
>> Helps with understanding how long it takes to do various
>> tasks.
>
> This feels too complex.. I don't really want to add N new #ifdef/#endif
> blocks for something like this, i.e., that should be cleaned up with
> conditionally defined inline functions (etc.) that keeps the source code
> readable.
>
> Timing can be figured out from debug log timestamps. If something is
> needed at runtime through control interface, I'd like to understand the
> use case better before adding this. In addition, this should most likely
> be using os_get_reltime() rather than os_get_time().

I wanted to get the info through the wpa_cli API.  The idea is to be able to
report the time it took to establish connection, do 4-way auth, anqp, etc.

Parsing logs is too complex, fragile, and in-efficient, especially with lots of virtual
stations.

I will be happy to re-write it with inline methods.  I think I do want os_get_time()
so I can compare time-stamps with other logs and other events if needed.

My use case is generating better reports for testing, and aside from that, this
feature is probably not that useful.  So, if you think some code cleanup would
be good enough to get this in, then I will work on re-spinning the patches.
But, if it is unlikely to ever be wanted upstream anyway, then please let me
know up front and I'll try to remember not to submit it again :)

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com