[PATCH 1/7] wpa_supplicant: fix null dereference

Peer, Ilan ilan.peer at intel.com
Tue Jan 20 02:39:31 EST 2015


Thanks :).

Ilan.

> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Tuesday, January 20, 2015 02:06
> To: Johannes Berg
> Cc: Peer, Ilan; Eytan Lifshitz; hostap at lists.shmoo.com
> Subject: Re: [PATCH 1/7] wpa_supplicant: fix null dereference
> 
> On Mon, Jan 19, 2015 at 10:49:14AM +0100, Johannes Berg wrote:
> > On Mon, 2015-01-19 at 09:47 +0000, Peer, Ilan wrote:
> > > True, but as the behavior is not defined in the specification, it
> > > really depends on the C library implementation.
> >
> > Yeah, I'm just not sure "??" is the best thing to print then? At least
> > that constitutes a difference in what users will see.
> 
> It looks like eap_server_get_name() is used only in debug and log messages
> and it should be fine to change its behavior for the unrecognized EAP type
> case. I don't think "(nil)" is a very good string to use here since it results in
> number of debug messages with "((nil))".
> I'll replace this with "unknown" which is at least more readable if nothing
> else. In addition, eap_server_get_name() function documentation needs to
> be updated (did that as well) to avoid leaving it claiming to return NULL if EAP
> method was not found.
> 
> --
> Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list