[PATCH 1/2] ibss: add WPA_DRIVER_FLAGS_HT_IBSS

Janusz Dziedzic janusz.dziedzic at tieto.com
Mon Jan 5 01:37:18 EST 2015


On 4 January 2015 at 14:20, Jouni Malinen <j at w1.fi> wrote:
> On Mon, Dec 29, 2014 at 08:14:58AM +0100, Janusz Dziedzic wrote:
>> Add WPA_DRIVER_FLAGS_HT_IBSS driver feature flag.
>> Some drivers could not set this feature and next could
>> fail when we will enable HT support (mac80211 based
>> drivers always have this flag set).
>> Move setting freq structure to the dedicated function.
>
>> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
>> @@ -1595,6 +1595,34 @@ void wpa_supplicant_associate(struct wpa_supplicant *wpa_s,
>
>> +static void ibss_setup_freq(struct wpa_supplicant *wpa_s, const struct wpa_ssid *ssid, struct hostapd_freq_params *freq)
>
>> +     if (!(wpa_s->drv_flags & WPA_DRIVER_FLAGS_HT_IBSS))
>> +             return;
>
>> @@ -1909,23 +1937,9 @@ static void wpas_start_assoc_cb(struct wpa_radio_work *work, int deinit)
>>
>>       /* Initial frequency for IBSS/mesh */
>>       if ((ssid->mode == WPAS_MODE_IBSS || ssid->mode == WPAS_MODE_MESH) &&
>
> Note that mesh part here..
>
>> +             ibss_setup_freq(wpa_s, ssid, &params.freq);
>
> Why would a function with ibss_ prefix be used with mesh? And why would
> HT_IBSS flag be used with mesh for that matter?
>
Will fix that.

BR
Janusz


More information about the HostAP mailing list