[PATCH 1/2] Add buf_eq() function to check buffers for equality

Jouni Malinen j at w1.fi
Sat Feb 28 09:22:33 EST 2015


On Mon, Jan 19, 2015 at 02:07:51PM +0100, Stefan Tomanek wrote:
> I've uploaded the branch to my github profile:
> 
> https://github.com/wertarbyte/hostap/compare/buf_eq
> 
> The three patches available there contain the new function, the semantic patch and
> formatting fixes (line lengths).

I'm not really convinced why this change would be useful. The latest
version you sent me directly has number of whitespace issues (does not
use tabs for indentation) and it breaks hostapd_cli build and increases
hostapd binary size. Unless there is some strong justification on why
this change helps with something significant, I'm tempted to just drop
it since the benefits are not obvious to me. In any case, I'm not
planning on applying this before v2.4 gets released and don't really
want to spend time on reviewing the changes without first understanding
the benefits.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list