[PATCH 17/24] tests: Modify test_autogo_bridge() test to use group interface

Jouni Malinen j at w1.fi
Sat Feb 7 03:36:32 EST 2015


On Fri, Feb 06, 2015 at 07:21:57AM +0000, Peer, Ilan wrote:
> > ... but I'm not that sure about move dev[0].remove_group() in this way.
> > That function can fail and raise an exception. I'd rather leave it where it was
> > and store the dev[0].get_group_ifname() result locally so that it can be used
> > in finally-processing.
> 
> This was the reason for this change. remove_group() has the logic to deduce what is the group interface name. I might be missing something here ..

The reason for that change was to use the group interface in the bridge
to make the test case work. The way this was done is not ideal for error
cases. remove_group() can raise an exception if it is called before the
group is formed and that can indeed be the case on the finally-path.
I'll fix the patch to do this in the way described above.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list