[PATCH 07/24] tests: Modify test_p2p_discovery to use global and group interfaces

Jouni Malinen j at w1.fi
Sat Feb 7 03:34:23 EST 2015


On Fri, Feb 06, 2015 at 07:20:33AM +0000, Peer, Ilan wrote:
> > > @@ -234,8 +236,8 @@ def test_discovery_social_plus_one(dev):
> > > -    dev[0].wait_event(["CTRL-EVENT-SCAN-STARTED"])
> > > -    dev[0].wait_event(["CTRL-EVENT-SCAN-STARTED"])
> > > +    dev[0].wait_global_event(["CTRL-EVENT-SCAN-STARTED"], timeout=1)
> > > +    dev[0].wait_global_event(["CTRL-EVENT-SCAN-STARTED"], timeout=1)
> > 
> > This looks bad, i.e., scan events should not really be global events.
> > The scan started events for p2p_find should actually just be removed
> > completely.
> 
> You mean you would like to see the events removed from the wpa_supplicant code? Would you like to see some other events, i.e., P2P_FIND_STARTED/STOPPED + P2P_SEARCH_STARTED/STOPPED etc.?

Yes, I'm thinking of removing CTRL-EVENT-SCAN-STARTED completely from
p2p_find cases and no, I would not replace it with P2P_SEARCH_STARTED.
The key point here is that it is of no real use to get that event every
300 ms or so during an ongoing p2p_find operation. The
CTRL-EVENT-SCAN-RESULTS was already removed from that case, but the
started event needs different handling. Anyway, I think I'll just drop
this part of your patch to avoid delaying the other parts getting in.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list