[PATCH 00/24] Modify tests to properly work with P2P Device as well

Jouni Malinen j at w1.fi
Thu Feb 5 07:10:40 EST 2015


On Wed, Feb 04, 2015 at 04:30:12AM -0500, Ilan Peer wrote:
> In our local setups we are using hwsim with P2P Device
> enabled. The following patch set includes modifications for
> the tests cases to allow them to pass also when P2P Device
> is supported. These mostly consist of:
> 
> 1. Using the global control interface for P2P commands and
>    events.
> 2. Using the relevant group interface name when needed.
> 3. Resolve cases that need to handle with multi interface
>    scenarios, e.g., assuming that the p2p_dev_addr == own_addr
> 
> Verified that the tests are passing also when the P2P Device is not
> enabled.

Thanks. I applied patches 1, 5, 8-15, 18-24. Patch 16 ('tests: Use
global control interface in test_nfc_p2p', I'd assume) did not make it
to the mailing list. Patches 2-4, 6-7, and 17 need changes as indicated
(or more justification to make me understand the reasoning for couple of
the items).

As a side note, it would be good to add new test cases that use P2P
Device enabled for areas that do not get full test coverage today. I
understand that this can be done by modifying support_p2p_device=0
parameter in the scripts, but that does not get executed automatically
at least in my test setups and running the full set of tests twice with
two values for that would result in significant duplication of testing,
so that's not going to happen either due to the extra time it would
take.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list