[PULL] Try to ensure we don't throw away the PIN unnecessarily

Jouni Malinen j at w1.fi
Sat Apr 25 12:39:53 EDT 2015


On Fri, Apr 17, 2015 at 03:17:19PM -0700, Mike Gerow wrote:
> This patch was a little big, so I opted to host it elsewhere and send a
> pull request since the list was bouncing it because of its size. If
> there's another way to make this easier let me know.

Thanks, applied with the changes described below.

>   Try to ensure we don't throw away the PIN unnecessarily (2015-04-15 17:57:51 -0700)

It sounds excessive to add a new build dependency on libp11 just to pull
in a single #define. I replaced that with that define in tls_openssl.c.

>  src/crypto/pkcs11.h           | 1357 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Similarly, adding that large a header file (and especially one with
license terms that are different from the ones used in hostap.git) is
not really desired for getting three #defines for return values. I added
those three defines into tls_openssl.c instead.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list