[PATCH] P2P : Add Operating class 125 for P2P supported channels

Ben Abdessalem, AmrX amrx.ben.abdessalem at intel.com
Fri Apr 3 05:03:23 EDT 2015


Hi,

This patch adds the opportunity to use channel 165  for example in P2P operations, depending of the wifi chip capabilities and also depending of the country code,
For "us" country code, the list is rather :
> ieee80211_chan_to_freq_us(u8 op_class, u8 chan)
> +	case 5: /* channels 149,153,157,161,165 */
I'm attaching the rectified patch, sorry for the mistake,
I didn't understand why it's not suitable to use LicenseExemptBehavior behavior for P2P, I think we are already using operating class 81, which is also LicenseExemptBehavior behavior (for Europe and United states,  but we are excluding some channels [12,13] ).
For 125 operating class, it's LicenseExemptBehavior behavior as global operating class, but not for Europe,

Regards,
Amr.

-----Original Message-----
From: Jouni Malinen [mailto:j at w1.fi] 
Sent: Friday, April 03, 2015 10:07 AM
To: Ben Abdessalem, AmrX
Cc: hostap at lists.shmoo.com; Bachot, Jean-michel
Subject: Re: [PATCH] P2P : Add Operating class 125 for P2P supported channels

On Thu, Apr 02, 2015 at 04:37:35PM +0000, Ben Abdessalem, AmrX wrote:
> Could you please consider the attached patch for merging ?
> It's about adding operating class 125 for P2P supported channels list.

Could you please clarify why this should be allowed for P2P use cases?
Class 124 covers the channels 149-161 that have been defined with the NomadicBehavior behavior limits set while Class 125 channels
149-165(169) have LicenseExemptBehavior behavior limits set that is for "some fixed stations [that] can be operated without a license at a higher radiated transmit power than permitted for nomadic use". For me, that reads as something that is not really suitable for P2P.

> diff --git a/src/common/ieee802_11_common.c 
> b/src/common/ieee802_11_common.c @@ -612,6 +612,10 @@ static int 
> ieee80211_chan_to_freq_us(u8 op_class, u8 chan)
> +	case 5: /* channels 149,153,157,169 */
> +		if (chan < 149 || chan > 169)
> +			return -1;
> +		return 5000 + 5 * chan;
> @@ -764,12 +768,15 @@ static int ieee80211_chan_to_freq_global(u8 
> op_class, u8 chan)
> +	case 125: /* channels 149,153,157,161,165,169 */
> +		if (chan < 149 || chan > 169)
> +			return -1;
> +		return 5000 + 5 * chan;

I'm fine with these in the generic (not specific to P2P) helper functions, but rest of the changes are P2P specific and need clearer justification on the applicability of LicenseExemptBehavior for P2P use cases.

-- 
Jouni Malinen                                            PGP id EFC895FA
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-P2P-Add-Operating-class-125-for-P2P-supported-channe.patch
Type: application/octet-stream
Size: 4401 bytes
Desc: 0001-P2P-Add-Operating-class-125-for-P2P-supported-channe.patch
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20150403/aa3ef353/attachment.obj>


More information about the HostAP mailing list