[PATCH-v2 2/4] hs20-client: use configured ca-fname instead of cwd.

Jouni Malinen j at w1.fi
Wed Apr 1 13:22:51 EDT 2015


On Tue, Mar 31, 2015 at 08:14:18PM -0400, greearb at candelatech.com wrote:
> This gives more flexibility to the hs20 client user.

> diff --git a/hs20/client/osu_client.c b/hs20/client/osu_client.c
> @@ -2036,11 +2036,19 @@ static int osu_connect(struct hs20_osu_client *ctx, const char *bssid,
> +			os_snprintf(fname, sizeof(fname), "%s/osu-ca.pem", dir);
> +			ctx->ca_fname = strdup(fname); /* so lib curl can use it. */

Wouldn't that prevent the existing test case where ctx.ca_fname is left
to NULL on purpose to avoid server certificate validation? In any case,
this strdup part looks independent of rest of the changes and should be
done in a separate commit (or more likely, not done at all, since I
think there is need to allow certificate validation to be disabled for
testing purposes).

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list