[PATCH] Android: Skip explicit conf_p2p_dev loading for main interface

Arend van Spriel arend at broadcom.com
Tue Sep 30 06:58:51 EDT 2014


On 09/29/14 19:35, Peer, Ilan wrote:
>
>>>> Related to this I created a patch that would make the -m option
>> redundant.
>>>> This is done by skipping networks and ignore 'p2p_disabled=1'
>>>> in the configuration when iface->p2p_mgmt is set.
>>>>
>>>
>>> Does this handle the case of update_config=1? In this case, if the
>> configuration file is shared between 2 different interfaces, one of them will
>> override the configuration of the other when wpa_supplicant exists or
>> instructed to save the config.
>>>
>>> Regardless, I think that the approach of have one global configuration file
>> to hold device wide configuration is cleaner and more scalable.
>>
>> Ah, I see. I thought the -m file contained P2P_DEVICE specific configuration,
>> but you are saying it should contain configuration items applicable to all
>> interfaces. I think the problem is that it is not straight-forward what the
>> usage level is of the configuration items.
>> Some are applicable to supplicant, some per-interface, and some only for a
>> specific type of interface.
>>
>
> The -m is not a good solution for handling global wide configuration but was introduced to overcome the clear issues we encountered having the P2P Device interface share the configuration file with the other interface. Jouni accepted the change but wants to have a solution with will better handle configuration items that are global. The below patches were an attempt to handle this:

I totally agree. When learning about the -m option I got a yuk feeling. 
I will check the patches.

Thanks,
Arend

> http://patchwork.ozlabs.org/patch/332033/
> http://patchwork.ozlabs.org/patch/332034/
> http://patchwork.ozlabs.org/patch/332035/
>
> Regards,
>
> Ilan.



More information about the HostAP mailing list