[PATCH] dbus: Add a device configuration entry to set the P2P WPS methods

Tomasz Bursztyka tomasz.bursztyka at linux.intel.com
Mon Sep 29 05:45:22 EDT 2014


Hi Jouni,

> On Tue, Sep 16, 2014 at 03:27:55PM +0300, Tomasz Bursztyka wrote:
>> It is thus possible to select which WPS methods is prefered for a P2P
>> device.
> I have nothing against making wpa_s->conf->config_methods configurable
> through D-Bus, but this commit message is confusing. First of all, this
> parameter is in no way specific to P2P, i.e., it applies to all WPS
> operations. Furthermore, it is not a preference; it is a list of all
> supported configuration methods and it should not really change unless
> the device capabilities changes.
>
> Could you please clarify how you are planning on using this and why this
> would be in P2P-specific D-Bus setter?

Indeed, let's change this.

I'll post another patch, and this will be set through global settings 
DBus interface.

Tomasz


More information about the HostAP mailing list