[PATCH v2 00/20] mesh support for wpa_supplicant

Bob Copeland me at bobcopeland.com
Sun Sep 28 22:07:19 EDT 2014


On Sun, Sep 28, 2014 at 09:45:12PM +0300, Jouni Malinen wrote:
> On Mon, Sep 01, 2014 at 12:23:19AM -0400, Bob Copeland wrote:
> > This is an updated posting of the mesh-for-wpa_supplicant patchset,
> > which allows creating an open or secure (SAE) 802.11s mesh.
> 
> It looks like this breaks number of TDLS hwsim test cases (both with and
> without CONFIG_MESH=y). This seems to be due to set_key failing for peer
> with "No such file or directory", i.e., likely missing a proper STA
> entry for the peer. Any idea why? driver_nl80211.c has changes in
> sta_add handler, so I'd assume those are related.

Hmm, yes, it looks like this restores passing on TDLS cases (but breaks
the mesh test cases).  I guess mesh MPM should just be setting supp_rates
when marking the sta authenticated.

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 44d07fe..4b0dad0 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -7754,11 +7754,12 @@ static int wpa_driver_nl80211_sta_add(void *priv,
 	NLA_PUT_U32(msg, NL80211_ATTR_IFINDEX, if_nametoindex(bss->ifname));
 	NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, params->addr);
 
+	NLA_PUT(msg, NL80211_ATTR_STA_SUPPORTED_RATES,
+		params->supp_rates_len, params->supp_rates);
+	wpa_hexdump(MSG_DEBUG, "  * supported rates",
+		    params->supp_rates, params->supp_rates_len);
+
 	if (!params->set) {
-		NLA_PUT(msg, NL80211_ATTR_STA_SUPPORTED_RATES,
-			params->supp_rates_len, params->supp_rates);
-		wpa_hexdump(MSG_DEBUG, "  * supported rates",
-			    params->supp_rates, params->supp_rates_len);
 
 		if (params->aid) {
 			wpa_printf(MSG_DEBUG, "  * aid=%u", params->aid);


> I pushed my temporary work branch ('mesh') into hostap.git to make it
> easier to see where I'm with the review and to send any additional
> patches on top of that version, if needed.

Great, thanks!

-- 
Bob Copeland %% www.bobcopeland.com


More information about the HostAP mailing list