[PATCH v2 00/20] mesh support for wpa_supplicant

Bob Copeland me at bobcopeland.com
Tue Oct 14 08:55:56 EDT 2014


On Sun, Oct 05, 2014 at 10:47:48PM +0300, Jouni Malinen wrote:
> I went through the initial review round and did some coding style
> cleanup and commit splitting to make this easier. I also ran the changes
> through couple of static analyzers and fixed the outcome (some
> allocations were no checked, etc., small things).
> 
> There were couple of violations of expected interface design in src/ap/*
> calling directly to wpa_supplicant/* which is not allowed. Similarly,
> wpa_supplicant/* cannot include src/ap/*_i.h (internal header files).
> Both of those were straightforward to fix, so those changes are in as
> well.

Awesome, thanks for this work!

> I pushed the current snapshot after all my changes into the mesh branch
> in hostap.git.
> 
> I still need to review the details of SAE changes since those can affect
> non-mesh cases. In addition, it would be nice to get somewhat more
> description commit messages for couple of the commits, like these:
> 
>     nl80211: Process mesh point interface like station interface
>     nl80211: Do not reset mesh point interface type on deinit
>     nl80211: Reject deauth/disassoc for mesh interface
>     nl80211: Do not set zero STA capability (mesh)
>     nl80211: Do not try to change supported rates
>     nl80211: set_key updates for mesh
>     nl80211: Add WPA_IF_MESH (TODO: why?)
>     write SAE key_mgmt to config

Due to some travel last week I didn't have a chance to review these yet
but I have some time this week, so I'll go back through them and document
what they are trying to do.  I would not be surprised if some of these bits
turn out to be unnecessary or invalid.

-- 
Bob Copeland %% www.bobcopeland.com


More information about the HostAP mailing list